[PATCH] D103441: [SLP] Avoid std::stable_sort(properlyDominates()).

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4311
+    assert(NodeB && "Should only process reachable instructions");
+    assert((NodeA == NodeB) == (NodeA->getDFSNumIn() == NodeB->getDFSNumIn()));
+    if (NodeA != NodeB)
----------------
(style) missing assert message


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5639
+  llvm::sort(CSEWorkList, [](const DomTreeNode *A, const DomTreeNode *B) {
+    assert((A == B) == (A->getDFSNumIn() == B->getDFSNumIn()));
+    return A->getDFSNumIn() < B->getDFSNumIn();
----------------
(style) missing assert message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103441/new/

https://reviews.llvm.org/D103441