[PATCH] D103422: [ADT] Move DenseMapInfo for APInt into APInt.h (PR50527)
Chris Lattner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 1 08:46:24 PDT 2021
lattner accepted this revision.
lattner added a comment.
This revision is now accepted and ready to land.
Thank you so much for tackling this!
================
Comment at: llvm/lib/Support/APInt.cpp:553
+unsigned DenseMapInfo<APInt>::getHashValue(const APInt &Key) {
+ return static_cast<unsigned>(hash_value(Key));
----------------
nikic wrote:
> craig.topper wrote:
> > Why is this out of line now?
> It avoids the need to include `Hashing.h` in `APInt.h` for the `hash_code` type.
I think this is fine - the implementation of hash_value is out of line just a few lines above anyway, so the whole function isn't going to be inlined in either case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103422/new/
https://reviews.llvm.org/D103422
More information about the llvm-commits
mailing list