[PATCH] D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3)

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 03:03:00 PDT 2021


xbolva00 added a comment.

In D102615#2790544 <https://reviews.llvm.org/D102615#2790544>, @mkazantsev wrote:

> In D102615#2790190 <https://reviews.llvm.org/D102615#2790190>, @xbolva00 wrote:
>
>> In D102615#2789636 <https://reviews.llvm.org/D102615#2789636>, @mkazantsev wrote:
>>
>>> In D102615#2788964 <https://reviews.llvm.org/D102615#2788964>, @xbolva00 wrote:
>>>
>>>> What are the latest compile time data for this patch?
>>>
>>> There have been several separate follow-ups to address the compile time, but I believe we never measured it all together.
>>
>> Could we get new data? @nikic? I am not sure if followups were not reverted as well so if follow up patches can recommited as NFC(I) patches, it would be great.
>
> The followups were all reverted and integrated into this one. I see no point in merging them separately, unless we want more pain with reverts (if it is needed again). They are just part of the algorithm.

Nice, so only this patch needs to tested for compile time. But if less than +0.5%, it should be acceptable. There were many improvements in ct, so I do think there is some space for less cheap optimizations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102615/new/

https://reviews.llvm.org/D102615



More information about the llvm-commits mailing list