[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

Mon May 31 21:59:46 PDT 2021

tlively accepted this revision.
tlively added a comment.

In D101140#2789199 <https://reviews.llvm.org/D101140#2789199>, @wingo wrote:

> Quick r? to @tlively -- OK with having the new util function in WebAssemblyFrameLowering?  It didn't work to have it in the utils library because the function needs the vtable of WebAssemblyFunctionInfo.

Yes, this sounds reasonable to me.

And regarding the target-specific additions to target-independent code, this addition also seems similar to how we have target-specific MVTs in the target-independent MVT list. Being able to add names (but usually not logic) for target-specific concepts to target-independent namespaces makes it much simpler to handle target-independent and target-specific things in a uniform way in the backends.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101140/new/

https://reviews.llvm.org/D101140