[PATCH] D103423: [lld/mac] Don't load DylibFiles from the DylibFile constructor

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 31 12:40:37 PDT 2021


tschuett added inline comments.


================
Comment at: lld/MachO/DriverUtils.cpp:204
   CachedHashStringRef path(mbref.getBufferIdentifier());
-  DylibFile *file = loadedDylibs[path];
+  DylibFile *&file = loadedDylibs[path];
   if (file)
----------------
Do you really the cute `&` hack? Can't you always do `loadedLibs[Path] = file;`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103423/new/

https://reviews.llvm.org/D103423



More information about the llvm-commits mailing list