[PATCH] D103190: [AMDGPU] Fix kernel LDS lowering for constants

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec created this revision.
rampitec added reviewers: arsenm, hsmhsm, JonChesterfield, ronlieb.
Herald added subscribers: foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
rampitec requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

There is a trivial but severe bug in the recent code collecting
LDS globals used by kernel. It aborts scan on the first constant
without scanning further uses. That leads to LDS overallocation
with multiple kernels in certain cases.


https://reviews.llvm.org/D103190

Files:
  llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp
  llvm/test/CodeGen/AMDGPU/ds_read2.ll
  llvm/test/CodeGen/AMDGPU/ds_write2.ll
  llvm/test/CodeGen/AMDGPU/lower-kernel-lds-constexpr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103190.348023.patch
Type: text/x-patch
Size: 12789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210526/1ebef8d1/attachment-0001.bin>