[PATCH] D103225: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

Sun May 30 21:49:27 PDT 2021

hsmhsm added a comment.

In D103225#2785585 <https://reviews.llvm.org/D103225#2785585>, @rampitec wrote:

> Note the failure: LLVM.CodeGen/AMDGPU::llc-pipeline.ll

Yes, I monitoring it. Not understanding why it is failing. Need to further look into it.

In D103225#2785687 <https://reviews.llvm.org/D103225#2785687>, @rampitec wrote:

> You probably need to wrap all prologue LDS stores into a block to execute it only from lane 0 and add a barrier after. @t-tye correct me if I am wrong.

But, I remember that we had decided to avoid barrier here, and instead just make sure that each thread within each wave execute the store instructions? In anycase, let me clarify it with @t-tye and @b-sumner.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103225/new/

https://reviews.llvm.org/D103225