[PATCH] D48803: Place the BlockAddress type in the address space of the containing function

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay requested changes to this revision.
dylanmckay added a comment.
This revision now requires changes to proceed.

My apologies for the couple month latency, almost every time I've checked this patch in the last few years there isn't any new activity. It looks like there's one comment from Matt last month that still needs to be addressed (remove a piece of error handling). Once updated, I'd like to get this approved.



================
Comment at: llvm/lib/AsmParser/LLParser.cpp:3459
+          if (!ExpectedTy->isPointerTy() ||
+              !ExpectedTy->getPointerElementType()->isIntegerTy(8))
+            return error(
----------------
arichardson wrote:
> arsenm wrote:
> > arichardson wrote:
> > > arsenm wrote:
> > > > This should not depend on pointee element types
> > > I've kept this check for now (with a TODO) and only updated the error message.
> > No, just rip out the type check. It's not needed now, and if it is, it's the verifier's responsibility to check it
> Will move check to verifier if there isn't one already.
The error

```
+          if (!ExpectedTy->isPointerTy())
+            return error(ID.Loc,
+                         "type of blockaddress must be a pointer and not '" +
+                             getTypeString(ExpectedTy) + "'");
```

still exists and hasn't been moved to the verifier or removed from this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48803/new/

https://reviews.llvm.org/D48803