[PATCH] D98335: [AVR] Refactor 8-bit & 16-bit shifts

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 30 04:47:51 PDT 2021


dylanmckay accepted this revision.
dylanmckay added a comment.
This revision is now accepted and ready to land.

Very nice design and simplification, looks good to me. Thank you for the link to Ayke's very nice blog post, as well as the detailed summary about your design and the tradeoffs within. It was also helpful that you kept the refactor and the optimizations themselves in separate patches, making this a non-functional change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98335/new/

https://reviews.llvm.org/D98335



More information about the llvm-commits mailing list