[PATCH] D103355: [InstrProfiling] Delete linkage/visibility toggling for Windows

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 29 21:22:55 PDT 2021


MaskRay added a subscriber: mstorsjo.
MaskRay added inline comments.


================
Comment at: compiler-rt/test/profile/Windows/coverage-linkage-lld.cpp:10
+// NOGC:   T ?discarded{{.*}}
+// GC-NOT: T ?discarded{{.*}}
----------------
An issue unrelated to this patch:

`discarded*` in coverage-linkage.cpp are discarded.

However, the weak symbol `weak` has weird mangling ` .weak.?weak@@YAXXZ.default.?discarded0@@YAXXZ` (how does it contain `discarded0` in its name)? @mstorsjo 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103355/new/

https://reviews.llvm.org/D103355



More information about the llvm-commits mailing list