[PATCH] D103370: WindowsSupport.h: do not depend on private config header

Andrew Kelley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 29 13:44:53 PDT 2021


andrewrk created this revision.
Herald added a subscriber: dexonsmith.
andrewrk requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

WindowsSupport.h is a public header, however if it gets included, will cause a compile error indicating that llvm/Config/config.h cannot be found. However there is no actual dependency on the private things in this header, so it can be changed to the public config header.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103370

Files:
  llvm/include/llvm/Support/Windows/WindowsSupport.h


Index: llvm/include/llvm/Support/Windows/WindowsSupport.h
===================================================================
--- llvm/include/llvm/Support/Windows/WindowsSupport.h
+++ llvm/include/llvm/Support/Windows/WindowsSupport.h
@@ -37,7 +37,7 @@
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
-#include "llvm/Config/config.h" // Get build system configuration settings
+#include "llvm/Config/llvm-config.h" // Get build system configuration settings
 #include "llvm/Support/Allocator.h"
 #include "llvm/Support/Chrono.h"
 #include "llvm/Support/Compiler.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103370.348658.patch
Type: text/x-patch
Size: 616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210529/216e3c84/attachment.bin>


More information about the llvm-commits mailing list