[PATCH] D103355: [InstrProfiling] Delete linkage/visibility toggling for Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

The main impact of this change seems to be that PGO data for non-comdat code is now `private` instead of `internal`. That's a good change: PGO data has really high object file size overhead, and LLD already discards PGO symbol names from the PDB because they are so large.

Non-comdat weak code mainly comes from uses of `__attribute__((weak))`, and this change will make corresponding PGO data weak as well. LLVM's implementation of weak linkage on COFF is really convoluted, so I'm not sure this is correct. Consider adding an integration test case for `__attribute__((weak))` to the compiler-rt profile test suite to see if this works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103355/new/

https://reviews.llvm.org/D103355