[PATCH] D101332: [llvm-objcopy] Exclude empty sections in IHexWriter output

Ian McIntyre via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 29 04:14:04 PDT 2021


mciantyre marked 2 inline comments as done.
mciantyre added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/ihex-writer-empty-sections.test:4
+
+# .data0 address
+# CHECK:         :02000004333394
----------------
jhenderson wrote:
> Nit: In newer llvm-objcopy tests, we use `##` for comments to distinguish them from FileCheck and lit directives.
Favored ## throughout, including comments of the inlined YAML.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101332/new/

https://reviews.llvm.org/D101332



More information about the llvm-commits mailing list