[PATCH] D103275: Update musttail verification to check all swiftasync->swiftasync tail calls.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 18:43:46 PDT 2021


efriedma added a comment.

If a swifttailcc function calls another swifttailcc in a non-tail position, the proposed rule is that it has to be marked notail?  Not sure I understand the justification here.  Is there some reason we need to forbid sibcall optimization of swifttailcc functions?

This might just be one of those unfortunate cases where we need to accept suspicious IR to avoid imposing awkward restrictions on optimizations.  If you're just trying to audit IR for suspicious constructs, we do have a separate "lint" pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103275/new/

https://reviews.llvm.org/D103275



More information about the llvm-commits mailing list