[PATCH] D103232: [AtomicExpandPass][AArch64] Promote xchg with floating-point types to integer ones

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 12:06:03 PDT 2021


efriedma added a comment.

The transform makes sense on targets that don't have atomic operations on floating-point registers, but that isn't all targets. In particular, the GPU targets have floating-point atomic operations, and bitcasting like this might get in the way of the natural lowering there.

If you think it makes sense to use a dedicated lowering hook, rather than extending AtomicExpansionKind, that's fine, I guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103232/new/

https://reviews.llvm.org/D103232



More information about the llvm-commits mailing list