[PATCH] D103328: [CodeGen][NFC] Remove unused virtual function

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 11:56:23 PDT 2021


myhsu marked an inline comment as done.
myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kFrameLowering.cpp:659
     if (PushedRegs)
-      emitCalleeSavedFrameMoves(MBB, MBBI, DL, true);
+      emitCalleeSavedFrameMoves(MBB, MBBI, DL);
   }
----------------
dblaikie wrote:
> Is this a change in behavior? Or is the 3 arg version just the 4 arg version with 'true' as the 4th arg?
This doesn't change any behavior. This function has always been 3 arguments until D101588, in which we added the 4-th argument only to conform with the virtual function prototype we're removing here. But the added 4-th argument has never been used at all in the function body so removing it is safe and doesn't change any behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103328/new/

https://reviews.llvm.org/D103328



More information about the llvm-commits mailing list