[PATCH] D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 10:34:29 PDT 2021


stefanp added a comment.

@mkazantsev 
I have reverted these changes (and subsequent related NFC patches) with the following patches:

  commit 0159652058ca555b05db6a209fe9cf660c3bf8e6 (HEAD -> main, origin/main, origin/HEAD)
  Author: Stefan Pintilie <stefanp at ca.ibm.com>
  Date:   Fri May 28 11:35:25 2021 -0500
  
      Revert "Return "[LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration" (try 2)"
      
      This reverts commit be1a23203b1de655b8c7dac7549818d975a0cbbf.
  
  commit 24bd657202379595b514ee17241f019294e86bc9
  Author: Stefan Pintilie <stefanp at ca.ibm.com>
  Date:   Fri May 28 11:35:12 2021 -0500
  
      Revert "[NFCI][LoopDeletion] Only query SCEV about loop successor if another successor is also in loop"
      
      This reverts commit b0b2bf3b5da950679db1431aae431a6dedea2245.
  
  commit fd553312031c7d8085fa6ee0755a957796eadf05
  Author: Stefan Pintilie <stefanp at ca.ibm.com>
  Date:   Fri May 28 11:34:02 2021 -0500
  
      Revert "[NFC] Formatting fix"
      
      This reverts commit 59d938e649e62db0cef4903d495e838fbc6a6eb8.
  
  commit 807fc7cdc97fc172b4967707a7718e7333351bff
  Author: Stefan Pintilie <stefanp at ca.ibm.com>
  Date:   Fri May 28 11:33:45 2021 -0500
  
      Revert "[NFC] Reuse existing variables instead of re-requesting successors"
      
      This reverts commit c467585682dcdda75e645ef3ab47c8b48440db12.
  
  commit dd226803c220f02a5987f0ee9f9ac3ffe2b35c09
  Author: Stefan Pintilie <stefanp at ca.ibm.com>
  Date:   Fri May 28 11:17:46 2021 -0500
  
      Revert "[NFCI][LoopDeletion] Do not call complex analysis for known non-zero BTC"
      
      This reverts commit 7d418dadf6b1e6fd9bcccf7c5b5e1db74992ee70.

When you are ready to commit I would be happy to test this patch on Power PC if you would like. It may help to avoid more noise on the buildbots.
Also, if you need help reproducing or investigating failures on Power PC I can help with that as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102615/new/

https://reviews.llvm.org/D102615



More information about the llvm-commits mailing list