[PATCH] D103321: [AMDGPU] Stop mulhi from doing 24 bit mul for uniform values

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 09:08:18 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h:166
+  bool hasSMulHi() const {
+    return HasSMulHi;
+  }
----------------
I would just put the >= GFX9 test in here. No need for a HasSMulHi field. There are plenty of precedents for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103321/new/

https://reviews.llvm.org/D103321



More information about the llvm-commits mailing list