[PATCH] D103280: [SDAG] try harder to fold casts into vector compare

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10950
+        auto isFreeToZext = [&](SDValue V) {
+          if (isConstantOrConstantVector(V))
+            return true;
----------------
lebedev.ri wrote:
> I strongly suspect you might want `/*NoOpaques=*/true`, and the default is wrong.
Good catch! Not sure how to expose it in a test, but I'll add that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103280/new/

https://reviews.llvm.org/D103280