[PATCH] D93305: [AMDGPU][GlobalISel] Transform (fadd (fmul x, y), z) -> (fma x, y, z)

[Jay Foad via Phabricator via llvm-commits]

foad added reviewers: aemerson, paquette.
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM but I'm adding a couple more globalisel reviewers. Please wait a couple more days in case they have comments.



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:797
+
+  /// Return true if target always beneficiates from combining into FMA for a
+  /// given value type. This must typically return false on targets where FMA
----------------
"benefits"


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2735
 
+  /// Returns true if be combined with to form a TargetOpcode::G_FMAD. \p N
+  /// may be an TargetOpcode::G_FADD, TargetOpcode::G_FSUB, or an
----------------
"if \p MI can be combined with another instruction to form"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93305/new/

https://reviews.llvm.org/D93305