[PATCH] D103280: [SDAG] try harder to fold casts into vector compare

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

`TODO`s sound fine to me.
LGTM assuming there are no other comments.
Thanks.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10950
+        auto isFreeToZext = [&](SDValue V) {
+          if (isConstantOrConstantVector(V))
+            return true;
----------------
I strongly suspect you might want `/*NoOpaques=*/true`, and the default is wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103280/new/

https://reviews.llvm.org/D103280