[PATCH] D103261: [AMDGPU] Increase alignment of LDS globals if necessary before LDS lowering.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 03:08:06 PDT 2021


hsmhsm marked an inline comment as done.
hsmhsm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.h:47
+// that we can use aligned LDS instructions to access them.
+void increaseAlignment(std::vector<GlobalVariable *> &LDSGlobals,
+                       const DataLayout &DL);
----------------
foad wrote:
> I think the first argument can be simpler: `ArrayRef<GlobalVariable *> LDSGlobals`.
Oh! yes, it much nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261



More information about the llvm-commits mailing list