[PATCH] D103261: [AMDGPU] If required, increase natural alignment of LDS globals before LDS lowering.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm marked 2 inline comments as done.
hsmhsm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:159-161
+    // If LDS has section defined, and it has its alignment explicitly
+    // specified, then we need to *honor* explicitly specified alignment whether
+    // it is under-aligned or not.
----------------
foad wrote:
> I think this needs a better explanation. Normally increasing the alignment would still be considered to "honor" the original alignment.
I was thinking about "#pragma clang section" defined for globals. But, now I think, it is not of a much meaning to LDS. And, I guess, it is programmatically and semantically fine to increase the alignment of LDS if it is necessary. Hence, remove the check itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261