[PATCH] D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 28 00:26:21 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:638
   ToolOutputFile OutputFile(OutputFilename, EC, sys::fs::OF_TextWithCRLF);
-  error("Unable to open output file" + OutputFilename, EC);
+  error("Unable to open output file " + OutputFilename, EC);
   // Don't remove output file if we exit with an error.
----------------
Whilst you're changing this message, I'd also change `Unable` to `unable`, in line with the LLVM error message style policy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103250/new/

https://reviews.llvm.org/D103250



More information about the llvm-commits mailing list