[PATCH] D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 23:23:39 PDT 2021


CarlosAlbertoEnciso added a comment.

In D103089#2779878 <https://reviews.llvm.org/D103089#2779878>, @amccarth wrote:

> I'm be happy to always generate uppercase hex digits when formatting a GUID to registry format, but maybe we should also consider accepting upper or lowercase when reading a formatted GUID.

My intention for this patch is to fix the fatal error in the yaml2obj tool.

I would suggest to open another change request to include the option to accept upper or lowercase. But if you feel that this patch should include that change, it is fine with me.

Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103089/new/

https://reviews.llvm.org/D103089



More information about the llvm-commits mailing list