[PATCH] D103199: Add flang-x86_64-windows builder.

Galina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 22:55:31 PDT 2021


gkistanova added a comment.

Frankly, I don't like the idea of allowing failing tests, definitely not in production. I see what you want to achieve with this, though.

How about not running tests in production till they are working properly, and have them on in the staging? You will have about the same result - test failures will not be reported nor annotated in github, but those who are interested could see the failures, analyze the logs, and reference particular builds. Once all the failing tests are sorted out and passing, they will be enabled in the production. You would have to have at least 2 workers for this setup. Would this do?



================
Comment at: buildbot/osuosl/master/config/builders.py:1623
+    'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
+                    clean=False,
+                    depends_on_projects=['llvm','mlir','clang','flang'],
----------------
Could you skip the `clean` arg to use the default, please?


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103199/new/

https://reviews.llvm.org/D103199



More information about the llvm-commits mailing list