[PATCH] D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 20:27:56 PDT 2021


Esme added a comment.

Hi @jasonliu @DiggerLin @sfertile @shchenz @hubert.reinterpretcast, I would appreciate it if you could review this patch and check if the file format is written properly in your opinion. Thanks in advance!



================
Comment at: llvm/test/tools/yaml2obj/XCOFF/basic-doc.yaml:38
+    NumberOfAuxEntries: 1
+  - Name:            i
+    Value:           0x0
----------------
jhenderson wrote:
> Does this symbol test anything unique any more, or can we drop it?
It was used to test StringTable before, but now it's useless. I will drop this in next update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95505/new/

https://reviews.llvm.org/D95505



More information about the llvm-commits mailing list