[PATCH] D100149: [AMDGPU][GlobalISel] Legalize and select G_SBFX and G_UBFX

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I assume we don't have any execution tests for this, but could really use some



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1613
+    auto AndHi = B.buildAnd(S32, UnmergeSOffset.getReg(1), SubHi);
+    B.buildMerge(DstReg, {AndLo, AndHi});
+    MI.eraseFromParent();
----------------
foad wrote:
> Looks like you're missing the sign extension here for the sbfe/sbfx case?
Yes, this looks suspicious


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100149/new/

https://reviews.llvm.org/D100149