[PATCH] D103129: [llvm-reduce] Don't delete arguments of intrinsics

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

could you also update the various comments to say that all functions, not just definitions, are touched?



================
Comment at: llvm/test/tools/llvm-reduce/remove-args-dbg-intrinsics.ll:3
+;
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=arguments --test=opt --test-arg=-verify --test-arg=-disable-output --output=%t %s
+; RUN: cat %t | FileCheck %s
----------------
aeubanks wrote:
> I don't think this is the right test, llvm-reduce already checks that something is verified. The test should be checking that each of the three intrinsics is declared (ignoring the arguments). Look at the other tests in the file for more examples.
I think this is still not quite right.
The llvm-reduce test should only be checking for the names of the functions, whereas the final test should check that everything is there. Other tests do something similar (e.g. remove-dso-local.ll)

so something like
```
CHECK-INTERESTINGNESS: declare void @llvm.dbg.addr
CHECK-INTERESTINGNESS: declare void @llvm.dbg.declare
CHECK-INTERESTINGNESS: declare void @llvm.dbg.value

CHECK-FINAL: declare void @llvm.dbg.addr(metadata, metadata, metadata)
CHECK-FINAL: declare void @llvm.dbg.declare(metadata, metadata, metadata)
CHECK-FINAL: declare void @llvm.dbg.value(metadata, metadata, metadata)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103129/new/

https://reviews.llvm.org/D103129