[PATCH] D103288: [SanCov] Properly set ABI parameter attributes
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 27 15:11:48 PDT 2021
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:892
+ IRB.CreateIntCast(A1, Ty, true)});
+ CB->setAttributes(CB->getCalledFunction()->getAttributes());
}
----------------
nit: on second thought, maybe it's simpler to use `CallbackFunc` rather than `CB->getCalledFunction()`. It seems silly to recompute that which is available in a local variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103288/new/
https://reviews.llvm.org/D103288
More information about the llvm-commits
mailing list