[PATCH] D103041: [SampleFDO] New hierarchical discriminator for FS SampleFDO (ProfileData part)

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.

lgtm, thanks.



================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:357
+  /// Pass == 0 is for using base discriminators.
+  void setDiscriminatorMaskedBitFrom(uint32_t Pass) {
+    MaskedBitFrom = getFSPassBitEnd(Pass);
----------------
maybe worth making a enum for FS-Passes. So it's obviously how we organize FS passes, and we don't need to pass int literals around. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103041/new/

https://reviews.llvm.org/D103041