[PATCH] D103288: [SanCov] Properly set ABI parameter attributes

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:845
+                              {IRB.CreateIntCast(A1, Ty, true)});
+    if (CallbackIdx == 0) {
+      CB->addParamAttr(0, Attribute::ZExt);
----------------
Can we do something like `CB->setAttributes(CB->getDirectCallee()->getAttributes()` that avoids duplicating the knowledge of the ABI attributes to the call site? We know at this point that the constructed call will be direct, nothing stops this code from looking at the callee.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103288/new/

https://reviews.llvm.org/D103288