[PATCH] D103275: Update musttail verification to check all swiftasync->swiftasync tail calls.

Varun Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 13:08:27 PDT 2021


varungandhi-apple added a comment.

> This doesn't look like a particularly expensive verifier check (although maybe I've missed something). What's the motivation for hiding it behind `EnableSwiftTailCCMustTailCheck`?

Having a flag makes it easier to turn off from Swift if we need to turn it off for some reason. Missing the `musttail` is technically not a fatal error, but it increases the risk of stack overflow if Swift doesn't generate the right IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103275/new/

https://reviews.llvm.org/D103275



More information about the llvm-commits mailing list