[PATCH] D103177: [flang][driver] Extend the `flang` bash script to act as a driver

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 12:11:04 PDT 2021


Meinersbur added a comment.

A concern that I have is that the bash script will only on platforms that have bash. In addition to Windows, some distribution use different default shells and may not have it installed (MacOS uses zsh and ships only an old version of bash).
However, as long as this is transitional, and to be removed again once  the flang toolchain is fully functional, I would be ok with it.

In D103177#2782881 <https://reviews.llvm.org/D103177#2782881>, @awarzynski wrote:

> Otherwise `flang`, the bash script, duplicates functionality available in `f18.cpp`. The goal is to move that functionality to `flang`.

I think the argument is that f18.cpp will be removed completely, not necessary to remove specific functionality before that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103177/new/

https://reviews.llvm.org/D103177



More information about the llvm-commits mailing list