[PATCH] D103269: [RISCV] Reserve an emergency spill slot for any RVV spills

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1443
+
+bool RISCVInstrInfo::isRVVSpill(unsigned Opcode) const {
+  return RISCVVPseudosTable::getPseudoInfo(Opcode) ||
----------------
craig.topper wrote:
> Is this checking for any RVV instruction rather than just spills?
Ah yes, it must be getting late. I hoisted it out of those tasteful lambdas where it was also checking the presence of FI operands. Even that isn't //technically// just checking for spills since it could and should detect a stack reference in a `vadd.vx` (for whatever reason).

Do you think this method sufficiently encapsulates something like `isRVVInstruction` and I can just rename it to that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103269/new/

https://reviews.llvm.org/D103269