[PATCH] D103261: [AMDGPU] Fix natural alignment of LDS globals during LDS lowering.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 09:55:45 PDT 2021


rampitec added a comment.

Thanks! I'd suggest to combine all fix-lds-alignmen*.ll tests into one. Just use different names for different blocks of variables so they are used only in one kernel.



================
Comment at: llvm/test/CodeGen/AMDGPU/lds-alignment.ll:131
 ; align 32, 16, 8
 ; 38 + (10 pad) + 38 + (2 pad) + 38 = 126
 ; HSA-LABEL: {{^}}test_round_size_3_order0:
----------------
Calculation comments need to be updated in the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261



More information about the llvm-commits mailing list