[PATCH] D103166: [AMDGPU] Fix function calls with flat scratch

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 348312.
sebastian-ne added a comment.

In D103166#2782087 <https://reviews.llvm.org/D103166#2782087>, @foad wrote:

> Does globalisel handle this?

Yes, it seems like globalisel handles adding the stack pointer in the `AMDGPUOutgoingArgHandler`. The code that adds the stack pointer in `AMDGPUInstructionSelector::selectMUBUFScratchOffset` is never hit, I’ll remove it.

I changed the handling in SDAG to match the one in GlobalISel. The stack pointer is now added when lowering call arguments and not when selecting instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103166/new/

https://reviews.llvm.org/D103166

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/callee-special-input-vgprs-packed.ll
  llvm/test/CodeGen/AMDGPU/callee-special-input-vgprs.ll
  llvm/test/CodeGen/AMDGPU/gfx-callable-argument-types.ll
  llvm/test/CodeGen/AMDGPU/non-entry-alloca.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103166.348312.patch
Type: text/x-patch
Size: 33937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210527/09c8dc02/attachment.bin>