[PATCH] D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo()

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/lib/IR/DebugInfo.cpp:390-391
+    return false;
+  if (Reachable.count(N) || isa<DILocation>(N))
+    return true;
+  if (!Visited.insert(N).second)
----------------
Do we need to remember that the MDNode was visited when it's a DILocation? 


================
Comment at: llvm/lib/IR/DebugInfo.cpp:410
 
   // if there is no debug location, we do not have to rewrite this MDNode.
+  if (!std::count_if(N->op_begin() + 1, N->op_end(), [&](const MDOperand &Op) {
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103220/new/

https://reviews.llvm.org/D103220