[PATCH] D103247: [SLP]Allow to reorder nodes with >2 scalar values.

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6568
+/// after:   6 3 5 4 7 2 1 0
+static void fixupOrderingIndicies(BoUpSLP::OrdersType &Order) {
+  const unsigned Sz = Order.size();
----------------
typo


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6615
     // TODO: reorder tree nodes without tree rebuilding.
     SmallVector<Value *, 4> ReorderedOps(Chain.rbegin(), Chain.rend());
+    llvm::transform(NewOrder, ReorderedOps.begin(),
----------------
this can be just Chain.size(). Following llvm::transform fills it in anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103247/new/

https://reviews.llvm.org/D103247