[PATCH] D103233: [Matrix] Preserve existing fast-math flags during lowering
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 27 08:18:46 PDT 2021
anemet added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1154
IRBuilder<> &Builder, bool IsTiled,
- bool IsScalarMatrixTransposed) {
+ bool IsScalarMatrixTransposed, Instruction *Inst) {
const unsigned VF = std::max<unsigned>(
----------------
fhahn wrote:
> I think it would be cleaner to just pass in the FMF object here? We don't need the instruction for anything else.
>
> Also, I think we don't need to separately pass in `AllowContraction` any longer?
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103233/new/
https://reviews.llvm.org/D103233
More information about the llvm-commits
mailing list