[PATCH] D103251: [NFC] Fix semantic discrepancy for MVT::LAST_VALUETYPE

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 07:30:17 PDT 2021


gchatelet added inline comments.


================
Comment at: llvm/include/llvm/Support/MachineValueType.h:39
       // ValueTypes.td as well!
-      Other          =   1,   // This is a non-standard value
-      i1             =   2,   // This is a 1 bit integer value
-      i8             =   3,   // This is an 8 bit integer value
-      i16            =   4,   // This is a 16 bit integer value
-      i32            =   5,   // This is a 32 bit integer value
-      i64            =   6,   // This is a 64 bit integer value
-      i128           =   7,   // This is a 128 bit integer value
+      Other = 1, // This is a non-standard value
+      i1 = 2,    // This is a 1 bit integer value
----------------
Unfortunately the Linter forced me to reformat this whole section.


================
Comment at: llvm/include/llvm/Support/MachineValueType.h:262-263
+      FIRST_VALUETYPE = 1,     // This is always the beginning of the list.
+      LAST_VALUETYPE = x86amx, // This always remains at the end of the list.
+      VALUETYPE_SIZE = LAST_VALUETYPE + 1,
 
----------------
The gist of this patch is the modification of these two lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103251/new/

https://reviews.llvm.org/D103251



More information about the llvm-commits mailing list