[PATCH] D103010: [PowerPC] Export 16 byte load-store instructions

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1253
+def RESTORE_QUADWORD : PPCEmitTimePseudo<(outs g8prc:$RTp), (ins memrix16:$src),
+                                        "#RESTORE_QUADWORD", []>;
+}
----------------
nit: misaligned - move right by one more space.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:1151
+
+  addFrameReference(BuildMI(MBB, II, DL, TII.get(PPC::STDX))
+                        .addReg(Reg, getKillRegState(IsKilled)),
----------------
Why use an X-Form for spilling/restoring rather than a D-Form the way all the other spilling code does? The FI eliminator should have what is needed to convert the D-Form to an X-Form (rather than relying on the pre-emit peephole which is what I assume is converting the X-Form to a D-Form in the attached test case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103010/new/

https://reviews.llvm.org/D103010