[PATCH] D103138: [AMDGPU] [IndirectCalls] Don't propagate attributes to address taken functions and their callees

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 02:37:01 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:118
 
+  CallGraph *ModuleCG;
+
----------------
madhur13490 wrote:
> foad wrote:
> > Add the nullptr initializion here instead of in the constructor?
> May I know why?
It's slightly better style because if you have more than one constructor, you don't have to repeat the same initialization value for every constructor. It doesn't really matter if you only have one constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103138/new/

https://reviews.llvm.org/D103138



More information about the llvm-commits mailing list