[PATCH] D103224: [VP] Make getMaskParamPos/getVectorLengthParamPos return unsigned. Lowercase function names.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 01:29:03 PDT 2021


frasercrmck added a comment.

I was tempted to do this while working on D103027 <https://reviews.llvm.org/D103027> so you get my LGTM. I'll let @simoll see it first though.



================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:297
 Value *VPIntrinsic::getMaskParam() const {
-  auto maskPos = GetMaskParamPos(getIntrinsicID());
-  if (maskPos)
-    return getArgOperand(maskPos.getValue());
+  auto MaskPos = getMaskParamPos(getIntrinsicID());
+  if (MaskPos)
----------------
You could fold this into the `if`s if you wanted. Same in `getVectorLengthParam`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103224/new/

https://reviews.llvm.org/D103224



More information about the llvm-commits mailing list