[PATCH] D102900: [llvm-readobj] Print function names with `--bb-addr-map`.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/bb-addr-map.test:20
 # LLVM-NEXT:     At: [[ADDR]]
+# LLVM-NEXT:     Name: ?
 # LLVM-NEXT:     BB entries [
----------------
I think you need to check the warning in this case too?


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6747
+          this->getSymbolIndexForFunctionAddress(AM.Addr, FunctionSec);
+      std::string FuncName = "?";
+      if (FuncSymIndex == None)
----------------
Elsewhere, we usually use `<?>` to indicate unknown names. Probably best to be consistent here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102900/new/

https://reviews.llvm.org/D102900