[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

Zakk Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 27 00:08:21 PDT 2021


khchen added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5
+; RUN: cat %s > %t.emptyabi
+; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi
+; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null
----------------
luismarques wrote:
> Is this something that we are handling in general, having such flag without a value?
Good cached, in general the target-abi is not empty, I updated the current implementation, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102582/new/

https://reviews.llvm.org/D102582



More information about the llvm-commits mailing list