[PATCH] D103212: [WIP] Changing CG Profile to relocations based.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 17:20:58 PDT 2021


MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:674
+      if (sec.sh_info == cgProfileSectionIndex) {
+        cgProfileRela = CHECK(getObj().relas(sec), this);
+      }
----------------
delete braces around one-line simple statements


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1857
+  // comes before section it applies to.
+  for (const Elf_Shdr &Sec : Sections) {
+    if (Sec.sh_info == DotCGProfileSecIndex) {
----------------
the loop should be skipped if DotCGProfileSecIndex is zero


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103212/new/

https://reviews.llvm.org/D103212



More information about the llvm-commits mailing list