[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked an inline comment as done.
yusra.syeda added inline comments.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:96-97
+            object_error::parse_failed,
+            "continued " + recordType(RecordType) +
+                " record is not followed by a continuation record");
+        return;
----------------
jhenderson wrote:
> Is there an index/ID/offset you could use in these messages? It will help users find the invalid record (since it may not be easy to identify which record has the specified type, if things are broken). Take a look at how llvm-readobj reports errors in ELF objects for some good examples.
> 
> Same goes for your other error messages.
I've added the record numbers to the error messages to make them more descriptive. Section indices which is used by ELF is not available in GOFF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437