[PATCH] D102582: [RISCV] Report an error when ABI mismatch with target-abi module flag.

[Luís Marques via Phabricator via llvm-commits]

luismarques added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:117
+      if (OptionABI != ModuleABI) {
+        Twine ErrMessage("Mismatch ABI. Current ABI is '" +
+                         RISCVABI::getABIName(OptionABI) +
----------------
"Mismatch" ABI -> "Mismatched ABIs" or "Mismatching ABIs".


================
Comment at: llvm/test/CodeGen/RISCV/module-target-abi-tests.ll:5
+; RUN: cat %s > %t.emptyabi
+; RUN: echo '!0 = !{i32 1, !"target-abi", !""}' >> %t.emptyabi
+; RUN: llc -mtriple=riscv32 < %t.emptyabi -o /dev/null
----------------
Is this something that we are handling in general, having such flag without a value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102582/new/

https://reviews.llvm.org/D102582