[PATCH] D101970: [X86FixupLEAs] Transform the sequence LEA/SUB to SUB/SUB

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 13:59:50 PDT 2021


Carrot added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FixupLEAs.cpp:437
+        // register is live.
+        MachineBasicBlock::iterator NextI = std::next(CurInst);
+        if (MBB.computeRegisterLiveness(TRI, X86::EFLAGS, NextI) !=
----------------
craig.topper wrote:
> Why can't we just check the Dead flag on the EFLAGS def of the ALU op?
Good catch!
I copied the code from optTwoAddrLEA.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101970/new/

https://reviews.llvm.org/D101970



More information about the llvm-commits mailing list